[Form][WCAG] Add hidden labels on date and time fields #26325
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Feb 27, 2018
stof
requested changes
Feb 27, 2018
| @@ -40,6 +40,16 @@ | |||
| <div {{ block('widget_container_attributes') }}> | |||
| {{- form_errors(form.date) -}} | |||
| {{- form_errors(form.time) -}} | |||
|
|
|||
| <div style="display:none"> | |||
There was a problem hiding this comment.
in a Bootstrap layout, it would be better to use the bootstrap class to hide these rather than an inline style. CSP may forbid using inline styles.
There was a problem hiding this comment.
There was a problem hiding this comment.
and btw, display:none hides it from screen readers too
Simperfit
approved these changes
Feb 27, 2018
Simperfit
approved these changes
Feb 27, 2018
nicolas-grekas
approved these changes
Feb 27, 2018
fabpot
approved these changes
Feb 28, 2018
|
Thank you @Nyholm. |
fabpot
added a commit
that referenced
this pull request
Feb 28, 2018
…holm) This PR was squashed before being merged into the 3.4 branch (closes #26325). Discussion ---------- [Form][WCAG] Add hidden labels on date and time fields | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | According to my friend and WCAG2 expect [Sandra](https://twitter.com/sandrability): > "Guidance texts" (my translation) on DateType and DateTimeType etc are missing. It is great that they are grouped with a "fieldset" but it will be more clear if there was a label on each select. Especially since different countries have different time and date formats. The time form is read like "00 00" and you have no idea if it is seconds, minutes or hours. You may do "guidance texts" visually hidden if you do not want to change the looks of the form. But since "month" is shorten to "Jan" instead of "January" you may want to have clear and visual guidance texts. Commits ------- 14978e9 [Form][WCAG] Add hidden labels on date and time fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my friend and WCAG2 expect Sandra: