[Form][WCAG] Added role="presentation" on tables & removed bootstrap4 table #26326
Conversation
This will prevent screen readers to read "row 1, column 1".
I agree. I'm the one who introduced the table layout in #20887 for the bootstrap 3 layout in order to provide a good-enough default output for this type. At the time, bootstrap 3 wasn't offering much (AFAIK) for displaying such a heavy type and my guess is that the base theme is overridden for most accessibility needs. |
|
As we are still doing fundamental changes to the Bootstrap 4 integration, wouldn't it be better to remove usage of tables as indicated by @ogizanagi? |
|
Thank you @ogizanagi for clearing this out. I did not know why we are using a table. @fabpot: Yes, we are still doing changes to the Bootstrap 4 theme. I will be done within a few (2-3) weeks. I suggest to "release" Bootstrap 4 theme with 4.1. I agree with you both. I think we should redo this without tables. I'll update the PR today |
|
Status: needs work |
|
What do you think about something like this: Before: After: |
|
Thank you @Nyholm. |
… bootstrap4 table (Nyholm) This PR was squashed before being merged into the 3.4 branch (closes #26326). Discussion ---------- [Form][WCAG] Added role="presentation" on tables & removed bootstrap4 table | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | According to my friend and WCAG2 expect [Sandra](https://twitter.com/sandrability): > Tables works best for table data, it should not be used for doing layouts. If you really really want to use the label add `role="presentation"`. This will make screen readers to ignore the table structure which will make it easier to navigate. It will also prevent screen readers to read "row 1, column 1". > But we should consider not using a table here. Commits ------- 635220a [Form][WCAG] Added role=\"presentation\" on tables & removed bootstrap4 table
|
Thank you for merging |
According to my friend and WCAG2 expect Sandra: