[HttpFoundation] split FileException into specialized ones about upload handling #26475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fmata
commented
Mar 9, 2018
•
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #26411 |
| License | MIT |
nicolas-grekas
approved these changes
Mar 14, 2018
soullivaneuh
approved these changes
Mar 15, 2018
fabpot
requested changes
Mar 15, 2018
| * | ||
| * @author Florent Mata <florentmata@gmail.com> | ||
| */ | ||
| class CantWriteFileException extends FileException |
There was a problem hiding this comment.
I would nose Cant here but Cannot instead.
There was a problem hiding this comment.
I wanted to follow the PHP const UPLOAD_ERR_CANT_WRITE to keep consistency, as others exceptions added in this PR. Are you sure of this change ?
There was a problem hiding this comment.
@fmata can you please do the change? (and rebase meanwhile to fix the small conflict)
There was a problem hiding this comment.
@nicolas-grekas rebased & updated
xabbuh
reviewed
Apr 2, 2018
| namespace Symfony\Component\HttpFoundation\File\Exception; | ||
|
|
||
| /** | ||
| * Thrown when an error UPLOAD_ERR_CANT_WRITE occurred with UploadedFile. |
There was a problem hiding this comment.
I would swap the word "error" and the name of the error.
|
Status: Needs Review |
lyrixx
approved these changes
Apr 2, 2018
|
Thank you @fmata. |
fabpot
added a commit
that referenced
this pull request
Apr 3, 2018
…ones about upload handling (fmata) This PR was merged into the 4.1-dev branch. Discussion ---------- [HttpFoundation] split FileException into specialized ones about upload handling | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26411 | License | MIT Commits ------- 9e586cc [HttpFoundation] split FileException into specialized ones about upload handling
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.