[Validator] String normalization options for string-based validators #26484

renan-taranto · 2018-03-11T01:56:36Z

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#26239
License	MIT
Doc PR	symfony/symfony-docs#9433

Todo:

Document the new options
Update Doc PR

Add trimming options to the string constraints.

src/Symfony/Component/Validator/Constraints/NotBlankValidator.php

Destroy666x · 2018-03-13T09:25:33Z

Looks good now, thanks. Some more edge cases (e.g. regular whitespaces) could be added for tests, but not sure how strict are they here yet

renan-taranto · 2018-03-13T23:44:53Z

Thanks for the review @Destroy666x.

src/Symfony/Component/Validator/Constraints/LengthValidator.php

src/Symfony/Component/Validator/Constraints/Length.php

xabbuh · 2018-04-01T19:11:55Z

Would it make sense to update other constraint validators too?

renan-taranto · 2018-04-06T13:49:12Z

Hey guys, how do you like this PR right now?

xabbuh · 2018-06-19T12:43:40Z

@renan-taranto For consistency, I would add this option to the other string constraints too.

src/Symfony/Component/Validator/Constraints/Email.php

src/Symfony/Component/Validator/Constraints/Ip.php

gmponos · 2018-10-09T21:06:54Z

Hello,

for me as a developer using symfony the normalizer option is a little bit confusing. I am referring to the naming of it. Maybe it's because in the syfmony world when I hear normalizer my mind goes to the Serializer component. So in the end when I saw the title of this PR I was expecting to see about an option that will be able to convert objects into strings and remove this code:

       if (!is_scalar($value) && !(\is_object($value) && method_exists($value, '__toString'))) {

I am not sure if the same confusion will be caused later for whatever reason. Therefore my suggestion would be formatter. Or simple trim and allowing this option to be either true or callable and if it is true just use plain trim. It's just a suggestion your call :)

ostrolucky · 2018-10-09T21:28:39Z

You can pass even callable which makes input pass the above check, it's your choice. Hence formatter is not good name.

renan-taranto · 2018-10-09T23:33:28Z

PR updated. AppVeyor broke due to the unrelated Symfony\Component\Process\Tests\ProcessTest.

nicolas-grekas

Could you please and a line in the changelog of the component?

src/Symfony/Component/Validator/Constraints/EmailValidator.php

src/Symfony/Component/Validator/Constraints/Email.php

renan-taranto · 2019-02-17T21:37:04Z

Hi @nicolas-grekas, is there anything else I can do for this PR?

fabpot · 2019-03-31T11:56:08Z

Thank you @renan-taranto.

…sed validators (renan-taranto) This PR was merged into the 4.3-dev branch. Discussion ---------- [Validator] String normalization options for string-based validators | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26239 | License | MIT | Doc PR | symfony/symfony-docs#9433 Todo: - [x] Document the new options - [x] Update Doc PR Add trimming options to the string constraints. Commits ------- 708d759 [Validator] String normalization options for string-based validators

This PR was merged into the master branch. Discussion ---------- [Validator] Document the "normalizer" option Documents the PR symfony/symfony#26484 Commits ------- 6eec07b [Validator] Document the "normalizer" option

carsonbot added Status: Needs Review Validator Feature labels Mar 11, 2018

renan-taranto force-pushed the string_normalization_options branch from df450ee to 226e532 Compare March 11, 2018 02:00

renan-taranto mentioned this pull request Mar 11, 2018

Add string normalization option(s) to string-based validators #26239

Closed

renan-taranto force-pushed the string_normalization_options branch 2 times, most recently from 7faf0e2 to 535259e Compare March 11, 2018 17:12

Destroy666x reviewed Mar 12, 2018

View reviewed changes

src/Symfony/Component/Validator/Constraints/NotBlankValidator.php Outdated Show resolved Hide resolved

nicolas-grekas added this to the 4.1 milestone Mar 12, 2018

renan-taranto force-pushed the string_normalization_options branch from 535259e to 4194fcf Compare March 12, 2018 23:37

Destroy666x approved these changes Mar 13, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Mar 13, 2018

renan-taranto mentioned this pull request Mar 13, 2018

[Validator] Document the "normalizer" option symfony/symfony-docs#9433

Merged

renan-taranto changed the title ~~[WIP] [Validator] String normalization options for string-based validators~~ [Validator] String normalization options for string-based validators Mar 13, 2018

renan-taranto force-pushed the string_normalization_options branch from 4194fcf to d1a0c02 Compare March 14, 2018 20:39

nicolas-grekas reviewed Mar 16, 2018

View reviewed changes

src/Symfony/Component/Validator/Constraints/LengthValidator.php Outdated Show resolved Hide resolved

ostrolucky reviewed Mar 18, 2018

View reviewed changes

src/Symfony/Component/Validator/Constraints/Length.php Outdated Show resolved Hide resolved

renan-taranto force-pushed the string_normalization_options branch from d1a0c02 to 8e6a52f Compare March 22, 2018 02:01

renan-taranto changed the title ~~[Validator] String normalization options for string-based validators~~ [WIP][Validator] String normalization options for string-based validators Mar 22, 2018

fabpot modified the milestones: 4.1, next Apr 22, 2018

nicolas-grekas approved these changes Jun 19, 2018

View reviewed changes

nicolas-grekas changed the title ~~[WIP][Validator] String normalization options for string-based validators~~ [Validator] String normalization options for string-based validators Jun 19, 2018

renan-taranto force-pushed the string_normalization_options branch from 8e6a52f to c21460a Compare June 19, 2018 21:35

renan-taranto force-pushed the string_normalization_options branch from a299b0b to 795acf3 Compare September 13, 2018 23:28

xabbuh reviewed Sep 24, 2018

View reviewed changes

src/Symfony/Component/Validator/Constraints/Email.php Outdated Show resolved Hide resolved

renan-taranto force-pushed the string_normalization_options branch from 795acf3 to a53a1fc Compare October 7, 2018 23:10

xabbuh reviewed Oct 9, 2018

View reviewed changes

src/Symfony/Component/Validator/Constraints/Email.php Outdated Show resolved Hide resolved

src/Symfony/Component/Validator/Constraints/Ip.php Outdated Show resolved Hide resolved

ostrolucky approved these changes Oct 9, 2018

View reviewed changes

renan-taranto force-pushed the string_normalization_options branch from 5d31a78 to 9da6661 Compare October 9, 2018 23:20

renan-taranto force-pushed the string_normalization_options branch from 9da6661 to 3a06897 Compare October 29, 2018 22:36

nicolas-grekas reviewed Dec 1, 2018

View reviewed changes

src/Symfony/Component/Validator/Constraints/EmailValidator.php Outdated Show resolved Hide resolved

renan-taranto force-pushed the string_normalization_options branch from 3a06897 to 202d8a2 Compare December 1, 2018 12:47

sstok reviewed Dec 2, 2018

View reviewed changes

src/Symfony/Component/Validator/Constraints/Email.php Show resolved Hide resolved

ro0NL mentioned this pull request Jan 29, 2019

[Validator] UrlValidator and UTF8-NFD #29953

Closed

renan-taranto force-pushed the string_normalization_options branch from 202d8a2 to 8bb60ea Compare February 17, 2019 21:10

ro0NL mentioned this pull request Feb 18, 2019

[Validator] Add allowSpaces and allowLowerCase option in IBAN/BIC constraints #30272

Closed

vudaltsov approved these changes Feb 19, 2019

View reviewed changes

[Validator] String normalization options for string-based validators

708d759

nicolas-grekas force-pushed the string_normalization_options branch from 7127d15 to 708d759 Compare March 13, 2019 15:39

nicolas-grekas added the Ready label Mar 13, 2019

fabpot approved these changes Mar 31, 2019

View reviewed changes

fabpot merged commit 708d759 into symfony:master Mar 31, 2019

renan-taranto deleted the string_normalization_options branch March 31, 2019 20:17

nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

fabpot mentioned this pull request May 9, 2019

Release v4.3.0-BETA1 #31435

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Validator] String normalization options for string-based validators #26484

[Validator] String normalization options for string-based validators #26484

renan-taranto commented Mar 11, 2018 •

edited

Loading

Destroy666x commented Mar 13, 2018 •

edited

Loading

renan-taranto commented Mar 13, 2018 •

edited

Loading

xabbuh commented Apr 1, 2018

renan-taranto commented Apr 6, 2018

xabbuh commented Jun 19, 2018

gmponos commented Oct 9, 2018

ostrolucky commented Oct 9, 2018

renan-taranto commented Oct 9, 2018

nicolas-grekas left a comment

renan-taranto commented Feb 17, 2019

fabpot commented Mar 31, 2019

[Validator] String normalization options for string-based validators #26484

[Validator] String normalization options for string-based validators #26484

Conversation

renan-taranto commented Mar 11, 2018 • edited Loading

Destroy666x commented Mar 13, 2018 • edited Loading

renan-taranto commented Mar 13, 2018 • edited Loading

xabbuh commented Apr 1, 2018

renan-taranto commented Apr 6, 2018

xabbuh commented Jun 19, 2018

gmponos commented Oct 9, 2018

ostrolucky commented Oct 9, 2018

renan-taranto commented Oct 9, 2018

nicolas-grekas left a comment

Choose a reason for hiding this comment

renan-taranto commented Feb 17, 2019

fabpot commented Mar 31, 2019

renan-taranto commented Mar 11, 2018 •

edited

Loading

Destroy666x commented Mar 13, 2018 •

edited

Loading

renan-taranto commented Mar 13, 2018 •

edited

Loading