[DI] Cleanup remainings from autoregistration #26634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Mar 22, 2018
| Q | A |
|---|---|
| Branch? | 4.0 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25959 |
| License | MIT |
| Doc PR | - |
3d5a111 to
0847a20
Compare
0847a20 to
74afff8
Compare
stof
reviewed
Mar 22, 2018
| { | ||
| $this->lastFailure = null; | ||
| $type = $reference->getType(); | ||
|
|
||
| if ($type !== (string) $reference || ($this->container->has($type) && !$this->container->findDefinition($type)->isAbstract())) { | ||
| return $reference; | ||
| } | ||
|
|
||
| if (!$reference->canBeAutoregistered()) { |
There was a problem hiding this comment.
is canBeAutoregistered still used anywhere ? AFAICT, this PR removes the only usages of the method. We should probably deprecate it.
There was a problem hiding this comment.
We should probably deprecate it.
Yes, we can now in 4.1
stof
approved these changes
Mar 22, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Mar 22, 2018
…kas) This PR was merged into the 4.0 branch. Discussion ---------- [DI] Cleanup remainings from autoregistration | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25959 | License | MIT | Doc PR | - Commits ------- 74afff8 [DI] Cleanup remainings from autoregistration
nicolas-grekas
added a commit
that referenced
this pull request
Mar 22, 2018
…nd getRequiringClass() (nicolas-grekas) This PR was merged into the 4.1-dev branch. Discussion ---------- [DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - ~Needs #26634~ Commits ------- 95fd81b [DI] deprecate TypedReference::canBeAutoregistered() and getRequiringClass()
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.