Adding support to bind scalar values to controller arguments #26658
Conversation
|
Failure is unrelated - unrelated segfault on a different component. |
|
Thank you @weaverryan. |
…uments (weaverryan) This PR was merged into the 4.1-dev branch. Discussion ---------- Adding support to bind scalar values to controller arguments | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25960 | License | MIT | Doc PR | symfony/symfony-docs#9477 Hi guys! This fixes (I think) the last rough edge with autowiring & error messages. 100% credit to @nicolas-grekas for this implementation - he has generously allowed me to steal his code in return for writing the test. I did test this on a real project. Cheers! Commits ------- 2c7198c Adding support to bind scalar values to controller arguments
…s (weaverryan) This PR was squashed before being merged into the master branch (closes #9477). Discussion ---------- Removing warning about bind + controller + scalar values Docs for symfony/symfony#26658 :) Commits ------- af00dbc adding version note about scalar bind args 4312518 Removing warning about bind + controller + scalar values
| $args[$p->name] = new Reference('value.'.$container->hash($bindingValue)); | ||
| $container->register((string) $args[$p->name], 'mixed') | ||
| ->setFactory('current') | ||
| ->addArgument(array($bindingValue)); |
There was a problem hiding this comment.
As this service is here to build a scalar, I should we should mark it as non-shared, to avoiding registering the scalar in $this->services
There was a problem hiding this comment.
why? what's the issue with sharing a scalar (or array btw?)
looks better shared to me, did I miss something?
|
|
||
| if (!$bindingValue instanceof Reference) { | ||
| continue; | ||
| $args[$p->name] = new Reference('value.'.$container->hash($bindingValue)); |
There was a problem hiding this comment.
I would use _value as prefix, to reduce the likeliness of conflicts with an actual service, as the YAML format forbids using the underscore prefix in service ids since 4.0.
|
Thinking about this one, how to you differentiate between something coming from the routing ( |
|
If I remember this correctly, the difference is the priority of the resolvers ... this one that resolves container params has low priority (lower than the routing one, which always wins over this one). |
Hi guys!
This fixes (I think) the last rough edge with autowiring & error messages. 100% credit to @nicolas-grekas for this implementation - he has generously allowed me to steal his code in return for writing the test. I did test this on a real project.
Cheers!