Improved the Ajax profiler panel when there are exceptions #26665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostrolucky
approved these changes
Mar 25, 2018
|
@ostrolucky the main problem is moving this line -> |
|
Yes I see your reasoning. I would do the same in most codebases too. |
fabpot
approved these changes
Mar 26, 2018
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2018
…ions (javiereguiluz) This PR was merged into the 4.1-dev branch. Discussion ---------- Improved the Ajax profiler panel when there are exceptions | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26646 | License | MIT | Doc PR | - This makes the following changes in the Ajax panel: * The `Profiler` column is now the first one. * When the response status code is `400` or higher, the profiler link points to the exception panel instead of the default request/response panel  Commits ------- 074d68d Improved the Ajax profiler panel when there are exceptions
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the following changes in the Ajax panel:
Profilercolumn is now the first one.400or higher, the profiler link points to the exception panel instead of the default request/response panel