[Messenger] Uses the messenger.message_handler tag instead of message.handler
#26676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not |
Why not. I like this option as well. Any other thoughts? |
nicolas-grekas
approved these changes
Mar 27, 2018
|
messenger.message_handler looks like the most explicit to me, and opens for more kind of handlers in the futur, if needed. |
fabpot
approved these changes
Mar 27, 2018
|
Thank you @sroze. |
fabpot
added a commit
that referenced
this pull request
Mar 27, 2018
…tead of `message.handler` (sroze) This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Uses the `messenger.message_handler` tag instead of `message.handler` | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no (technically, it's not even in 4.1) | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT After a few days using it, it feels weird to have the `messenger.receiver` and `messenger.sender` tags while the one for message handlers is `message_handler`. I believe that for consistency, this would make sense to rename this tag `messenger.message_handler`. As we don't have tests for this pass yet (will be added in #26672) there is nothing else to change (but the documentation). Commits ------- bddebc4 Uses the `messenger.message_handler` tag instead of `message.handler`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a few days using it, it feels weird to have the
messenger.receiverandmessenger.sendertags while the one for message handlers ismessage_handler. I believe that for consistency, this would make sense to rename this tagmessenger.message_handler.As we don't have tests for this pass yet (will be added in #26672) there is nothing else to change (but the documentation).