Improved the lint:xliff command #26682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stloyd
suggested changes
Mar 27, 2018
| @@ -242,4 +254,16 @@ private function isReadable($fileOrDirectory) | |||
|
|
|||
| return $default($fileOrDirectory); | |||
| } | |||
|
|
|||
| private function getTargetLanguageFromFile($xliffContents) | |||
There was a problem hiding this comment.
private function getTargetLanguageFromFile(\DOMDocument $xliffContents): ?string
{
foreach ($xliffContents->getElementsByTagName('file')[0]->attributes ?? array() as $attribute) {
if ('target-language' === $attribute->nodeName) {
return $attribute->nodeValue;
}
}
return null;
}
stof
requested changes
Mar 27, 2018
| } | ||
|
|
||
| if (false === $document->schemaValidate(__DIR__.'/../Resources/schemas/xliff-core-1.2-strict.xsd')) { | ||
| $errors[] = array_map(function ($error) { |
There was a problem hiding this comment.
are you sure about it ? This will add an array of errors a a single entry in $errors. This looks weird to me
There was a problem hiding this comment.
btw, your new test does not seem to cover this code path
fabpot
requested changes
Mar 28, 2018
|
|
||
| libxml_clear_errors(); | ||
| libxml_use_internal_errors(false); | ||
|
|
||
| return array('file' => $file, 'valid' => false, 'messages' => $errorMessages); | ||
| return array('file' => $file, 'valid' => empty($errors), 'messages' => $errors); |
There was a problem hiding this comment.
Can you avoid using empty() here?
javiereguiluz
added a commit
to symfony/demo
that referenced
this pull request
Mar 28, 2018
This PR was merged into the master branch. Discussion ---------- Fixed minor issues in the XLIFF files Spotted thanks to the latest improvement of `lint:xliff`: symfony/symfony#26682 Commits ------- 2020233 Fixed minor issues in the XLIFF files
stof
requested changes
Mar 29, 2018
| * | ||
| * @author Javier Eguiluz <javier.eguiluz@gmail.com> | ||
| */ | ||
| class XliffLintCommandTest extends TestCase |
There was a problem hiding this comment.
This test should go in the component, as the command is in the component (well, we may need to have 2 different tests). This should fix the deps=low build too, by having the test for the new feature in the same package than the feature itself.
stof
approved these changes
Mar 29, 2018
fabpot
approved these changes
Mar 30, 2018
|
Thank you @javiereguiluz. |
fabpot
added a commit
that referenced
this pull request
Mar 30, 2018
This PR was squashed before being merged into the 4.1-dev branch (closes #26682). Discussion ---------- Improved the lint:xliff command | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26537 | License | MIT | Doc PR | - This is how it looks:  Commits ------- 6bbcc45 Improved the lint:xliff command
Merged
sayjun0505
added a commit
to sayjun0505/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was merged into the master branch. Discussion ---------- Fixed minor issues in the XLIFF files Spotted thanks to the latest improvement of `lint:xliff`: symfony/symfony#26682 Commits ------- 2020233 Fixed minor issues in the XLIFF files
spider-yamet
added a commit
to spider-yamet/sym_proj
that referenced
this pull request
Apr 16, 2023
This PR was merged into the master branch. Discussion ---------- Fixed minor issues in the XLIFF files Spotted thanks to the latest improvement of `lint:xliff`: symfony/symfony#26682 Commits ------- 2020233 Fixed minor issues in the XLIFF files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how it looks: