Add PHPDbg support to HTTP components #26749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
requested changes
Apr 2, 2018
| @@ -372,7 +372,7 @@ public function send() | |||
|
|
|||
| if (function_exists('fastcgi_finish_request')) { | |||
| fastcgi_finish_request(); | |||
| } elseif ('cli' !== PHP_SAPI) { | |||
| } elseif (!in_array(PHP_SAPI, array('cli', 'phpdbg'))) { | |||
There was a problem hiding this comment.
Could you update your code with } elseif (!\in_array(PHP_SAPI, array('cli', 'phpdbg'), true)) {
|
@lyrixx Thanks for the quick review! I did check every usage of |
|
I've just unified the code style in all checks. |
|
Important consideration is these would need to be re-checked in 2.8, 3.4, 4.0 etc. |
lyrixx
approved these changes
Apr 2, 2018
fabpot
approved these changes
Apr 3, 2018
|
Thank you @hkdobrev. |
fabpot
added a commit
that referenced
this pull request
Apr 3, 2018
This PR was squashed before being merged into the 2.7 branch (closes #26749). Discussion ---------- Add PHPDbg support to HTTP components | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This is a follow-up to #26677. Turns out there aren't that many remaining instances of `PHP_SAPI` checks without considering `phpdbg` where it's needed. Commits ------- 60dd79c Add PHPDbg support to HTTP components
This was referenced Apr 3, 2018
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #26677.
Turns out there aren't that many remaining instances of
PHP_SAPIchecks without consideringphpdbgwhere it's needed.