[Form] Fix precision of MoneyToLocalizedStringTransformer's divisions on transform() #26781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5dff4ee to
5653b4e
Compare
05c0aba to
65e0b29
Compare
65e0b29 to
bddc80d
Compare
stof
reviewed
Apr 4, 2018
| @@ -710,6 +710,7 @@ private function round($value, $precision) | |||
| } elseif (isset(self::$customRoundingList[$roundingModeAttribute])) { | |||
| $roundingCoef = pow(10, $precision); | |||
| $value *= $roundingCoef; | |||
| $value = (float) (string) $value; | |||
There was a problem hiding this comment.
why first casting to string and then to float again ? The *= operator means that this is probably not a string already. What happens if you remove this ?
| @@ -428,6 +428,7 @@ public function formatRoundingModeRoundHalfUpProvider() | |||
| // array(1.125, '1.13'), | |||
| array(1.127, '1.13'), | |||
| array(1.129, '1.13'), | |||
| array(1020 / 100, '10.20'), | |||
There was a problem hiding this comment.
why not 10.2 rather than a division ?
There was a problem hiding this comment.
Are you sure about that example? https://3v4l.org/5ZV3F does not confirm your observation. Should we use another example instead that allows to actually catch potential future regressions?
There was a problem hiding this comment.
@xabbuh yes, you forgot to add floor().
nicolas-grekas
approved these changes
Apr 4, 2018
|
Don't we have the same issue in 2.7? |
|
I think so. #24036 was merged into |
xabbuh
requested changes
Apr 20, 2018
...omponent/Form/Tests/Extension/Core/DataTransformer/MoneyToLocalizedStringTransformerTest.php
Outdated
Show resolved
Hide resolved
bddc80d to
b97a4ae
Compare
b25e32b to
f94b7aa
Compare
|
done |
nicolas-grekas
approved these changes
May 15, 2018
xabbuh
approved these changes
May 15, 2018
|
Thank you @syastrebov. |
fabpot
added a commit
that referenced
this pull request
May 17, 2018
…s divisions on transform() (syastrebov) This PR was merged into the 2.7 branch. Discussion ---------- [Form] Fix precision of MoneyToLocalizedStringTransformer's divisions on transform() | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | Related issue #21026. Previous PR #24036. Similar fix for `transform()` method. Commits ------- f94b7aa fix rounding from string
This was referenced May 21, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #21026.
Previous PR #24036.
Similar fix for
transform()method.