-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Finder] fix tests #26785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Finder] fix tests #26785
Conversation
xabbuh
commented
Apr 4, 2018
Q | A |
---|---|
Branch? | 2.7 |
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | |
License | MIT |
Doc PR |
This is a quick fix to make the test suite green again. However, as you can see the path normalization handling has always been dependent on the adapter that you used. I wonder if we shouldn't rather remove these new tests to not make any misleading promises about how the resulting path will be represented. |
Hm, very good point (and sorry that I missed the test failures). Haven't looked into how these adapters are calling find, but from a naive approach on command line,
Output:
Whether to remove the tests or not, depends on whether we agree Finder should fulfill their expectations. The introduced expectations do make sense, as I pointed out here. But of course would be as well quite breaking for a bugfix version. Last but not least, I haven't checked yet if the implementation would be reasonably doable at all. I could help out in any direction, but obviously needs a decision from Symfony how to proceed. |
see https://github.com/symfony/symfony/blob/2.7/src/Symfony/Component/Finder/Adapter/AbstractFindAdapter.php#L42 where |
Well, these adapters are deprecated though. But rather than using |
Hm, ok. Don't know why this was added. Can't confirm that
Ah OK, then I would just go with skipping these tests, as the adapters are gone in master anyway. |
Thank you @xabbuh. |
This PR was merged into the 2.7 branch. Discussion ---------- [Finder] fix tests | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 540ea11 [Finder] fix tests
Thanks @nicolas-grekas @xabbuh and everybody else involved. |