[PhpUnitBridge] Search for SYMFONY_PHPUNIT_REMOVE env var in phpunit.xml then phpunit.xml.dist #26800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xml then phpunit.xml.dist
fabpot
approved these changes
Apr 4, 2018
ogizanagi
approved these changes
Apr 4, 2018
stof
approved these changes
Apr 4, 2018
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Apr 4, 2018
…var in phpunit.xml then phpunit.xml.dist (lyrixx) This PR was merged into the 4.1-dev branch. Discussion ---------- [PhpUnitBridge] Search for SYMFONY_PHPUNIT_REMOVE env var in phpunit.xml then phpunit.xml.dist | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | --- using the env var could be a bit annoying + not everyone may know this. So adding it to the `phpunit.xml.dist` file make sens IHMO Commits ------- 5e2d43e [PhpUnitBridge] Search for SYMFONY_PHPUNIT_REMOVE env var in phpunit.xml then phpunit.xml.dist
|
could be worth doing the same with the other env vars that configure the bridge (version and dir?) |
|
Okay. Il will do that |
fabpot
added a commit
that referenced
this pull request
Apr 5, 2018
… phpunit.xml then phpunit.xml.dist (lyrixx) This PR was merged into the 4.1-dev branch. Discussion ---------- [PhpUnitBridge] Search for other SYMFONY_* env vars in phpunit.xml then phpunit.xml.dist | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26800 (comment) | License | MIT | Doc PR | Commits ------- 3b1c582 [PhpUnitBridge] Search for other SYMFONY_* env vars in phpunit.xml then phpunit.xml.dist
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the env var could be a bit annoying + not everyone may know this. So adding it to the
phpunit.xml.distfile make sens IHMO