[Messenger][FrameworkBundle] Move collector, command into the component & minor tweaks #26816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Apr 6, 2018
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Apr 6, 2018
…the component & minor tweaks (ogizanagi) This PR was squashed before being merged into the 4.1-dev branch (closes #26816). Discussion ---------- [Messenger][FrameworkBundle] Move collector, command into the component & minor tweaks | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Some suggestions more aligned with most of the core practices, mainly: - Move the command & collector to the component itself. They are not dependent of the Fwb in any way and are useful out of the fwb usage. - Add an exception in FrameworkExtension if the `framework.messenger` key is enabled, but the component isn't installed. Commits ------- 6aec62b [FrameworkBundle] Minor messenger component tweaks f9c9ca0 [Messenger] Move data collector & command into the component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some suggestions more aligned with most of the core practices, mainly:
framework.messengerkey is enabled, but the component isn't installed.