[Validator] Fix LazyLoadingMetadataFactory with PSR6Cache for non classname if tested values isn't existing class #26823
Conversation
|
Symfony 3.1 is not maintained anymore 😉 I guess the lowest maintained affected branch is 3.4? Before that there is no PSR-6 Cache. But I think its fine to target even 2.7 for consistency? I would wait for a symfony member to confirm 😉 |
| ->method('read') | ||
| ->with($testedValue) | ||
| ->willThrowException(new InvalidArgumentException(sprintf('Cache key "%s" contains reserved characters {}()/\@:', $testedValue))); | ||
| $this->expectException(NoSuchMetadataException::class); |
There was a problem hiding this comment.
if we target 2.7 then we need to support php 5.3 here
| $cache | ||
| ->method('read') | ||
| ->with($testedValue) | ||
| ->willThrowException(new InvalidArgumentException(sprintf('Cache key "%s" contains reserved characters {}()/\@:', $testedValue))); |
There was a problem hiding this comment.
just assert that we never actually call $cache->read(...)?
| $this->expectException(NoSuchMetadataException::class); | ||
| try { | ||
| $factory->getMetadataFor($testedValue); | ||
| } catch (InvalidArgumentException $exception) { |
There was a problem hiding this comment.
no need for this then. We expect NoSuchMetadataException::class and if not the test just fails
|
@dmaicher : Sorry. Too worried to not forget a comment, to find the right way to create patchs and I forgot the most important : the bug... 😄 |
| @@ -90,17 +90,17 @@ public function getMetadataFor($value) | |||
| return $this->loadedClasses[$class]; | |||
| } | |||
|
|
|||
| if (!class_exists($class) && !interface_exists($class)) { | |||
There was a problem hiding this comment.
just one change please: false should be passed as 2nd arg to interface_exists() (no need to trigger autoloader twice)
…ssname if tested values isn't an existing class
|
Thank you @pmontoya. |
…for non classname if tested values isn't existing class (Pascal Montoya, pmontoya) This PR was merged into the 2.7 branch. Discussion ---------- [Validator] Fix LazyLoadingMetadataFactory with PSR6Cache for non classname if tested values isn't existing class | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26313 | License | MIT If @Assert\Valid is applied to a string value, the value is searched in metadata cache and some characters aren't allowed in this cache. This create an unexpected exception. Class existence is now tested before cache read. Commits ------- 5198f43 Disable autoloader call on interface_exists check cd91420 [Validator] Fix LazyLoadingMetadataFactory with PSR6Cache for non classname if tested values isn't an existing class
If @Assert\Valid is applied to a string value, the value is searched in metadata cache and some characters aren't allowed in this cache. This create an unexpected exception.
Class existence is now tested before cache read.