[Bridge/Doctrine] count(): Parameter must be an array or an object that implements Countable #26831
Conversation
| @@ -155,7 +155,7 @@ public function validate($entity, Constraint $constraint) | |||
| * which is the same as the entity being validated, the criteria is | |||
| * unique. | |||
| */ | |||
| if (0 === count($result) || (1 === count($result) && $entity === ($result instanceof \Iterator ? $result->current() : current($result)))) { | |||
| if (null === $result || 0 === count($result) || (1 === count($result) && $entity === ($result instanceof \Iterator ? $result->current() : current($result)))) { | |||
There was a problem hiding this comment.
Would it be an option to use is_countable via the polyfill?
There was a problem hiding this comment.
Ah it seems like it's not available (yet): https://github.com/symfony/polyfill-php73 /cc @nicolas-grekas
|
Well, if your method returns The UniqueEntityValidator expects a results corresponding to |
|
@stof indeed. Another way to fix is to ensure item is an array. What do you think about? |
|
I think we should throw an exception then. |
|
@xabbuh With php7.1, no trouble with this. Throw an exception will be a breaking change. |
|
What result would you expect here if you do not return a countable collection? |
|
Actually, even the "instanceof Iterator" case is broken, because not all iterators are countable. Here is an alternative proposal that should do it: --- a/src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntityValidator.php
+++ b/src/Symfony/Bridge/Doctrine/Validator/Constraints/UniqueEntityValidator.php
@@ -132,16 +132,26 @@ class UniqueEntityValidator extends ConstraintValidator
* iterator implementation.
*/
if ($result instanceof \Iterator) {
$result->rewind();
+ $result = $result instanceof \Countable && 1 < count($result) ? array($result->current(), $result->current()) : (array) $result->current();
} elseif (is_array($result)) {
reset($result);
+ } else {
+ $result = (array) $result;
}
/* If no entity matched the query criteria or a single entity matched,
* which is the same as the entity being validated, the criteria is
* unique.
*/
- if (0 === count($result) || (1 === count($result) && $entity === ($result instanceof \Iterator ? $result->current() : current($result)))) {
+ if (!$result || (1 === \count($result) && current($result) === $entity)) {
return;
} |
| $result = array($result->current(), $result->current()); | ||
| } else { | ||
| $result = $result->current(); | ||
| $result = null === $result ? array() : array($result); |
There was a problem hiding this comment.
Should we also account for iterators that have more than one result?
There was a problem hiding this comment.
I fear this could consume the iterator, could be an issue with non-rewindable ones
There was a problem hiding this comment.
hm indeed, we should rather not break that, might be a good idea to deprecate some of the edge cases we currently try to handle
|
Thank you @gpenverne. |
…n object that implements Countable (gpenverne) This PR was merged into the 2.7 branch. Discussion ---------- [Bridge/Doctrine] count(): Parameter must be an array or an object that implements Countable | Q | A | ------------- | --- | Branch? | master | | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Php7.2 will throw a warning on count(null) [http://php.net/manual/en/migration72.incompatible.php](http://php.net/manual/en/migration72.incompatible.php) Error: ``` count(): Parameter must be an array or an object that implements Countable ``` when no result returned on validating unique constraint For example, on an entity with annotation uniqueEntity: ``` @UniqueEntity( fields={"email"}, repositoryMethod="findMemberWithPasswordFromEmail", ) ``` And in repository, a method ``findMemberWithPasswordFromEmail`` which return null if no entity found (``getOneOrNullResult``) Commits ------- 715373f [Bridge/Doctrine] fix count() notice on PHP 7.2
Php7.2 will throw a warning on count(null) http://php.net/manual/en/migration72.incompatible.php
Error:
when no result returned on validating unique constraint
For example, on an entity with annotation uniqueEntity:
And in repository, a method
findMemberWithPasswordFromEmailwhich return null if no entity found (getOneOrNullResult)