[MonologBridge] Added WebSubscriberProcessor to ease processor configuration #26832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, I don't need to add a new class to preserve the BC, right ? |
fabpot
requested changes
Apr 22, 2018
| 4.1.0 | ||
| ----- | ||
|
|
||
| * Added `WebSubscriberProcessor` to be easily autoconfigured |
There was a problem hiding this comment.
I don't understand the meaning of this sentence. What is easily configured?
| } | ||
|
|
||
| /** | ||
| * WebProcessor override to read from the HttpFoundation's Request and to be autoconfigured. |
There was a problem hiding this comment.
Sorry, but I don't understand what that means as well (I see that you copy/pasted the one from WebProcessor, but the second part is quite cryptic to me).
|
I have update the PR:
Before: Symfony\Bridge\Monolog\Processor\WebProcessor:
tags:
- { name: monolog.processor }
- { name: kernel.event_listener, event: kernel.request, priority: 4096 }After: Symfony\Bridge\Monolog\Processor\WebProcessor:
tags: [ monolog.processor ] |
@fabpot I don't see your comments :/ |
fabpot
reviewed
Apr 23, 2018
| 4.1.0 | ||
| ----- | ||
|
|
||
| * `WebProcessor` now implements EventSubscriberInterface in order to be easily autoconfigured |
There was a problem hiding this comment.
missing quotes around EventSubscriberInterface
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
Apr 23, 2018
…rocessor configuration (lyrixx) This PR was merged into the 4.1-dev branch. Discussion ---------- [MonologBridge] Added WebSubscriberProcessor to ease processor configuration | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | --- Side note: I could be nice to have an interface to act as the marker to AutoConfigure processors Commits ------- b1287d6 [MonologBridge] Added WebSubscriberProcessor to ease processor configuration
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Side note: I could be nice to have an interface to act as the marker to AutoConfigure processors