[DI] Improve error message for non-autowirable scalar argument #26856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Apr 7, 2018
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #26838 |
| License | MIT |
| Doc PR | - |
Tobion
reviewed
Apr 7, 2018
| if ($type = ProxyHelper::getTypeHint($reflectionMethod, $parameter, false)) { | ||
| $message = 'Cannot autowire service "%s": argument "%s $%s" of method "%s()" must be given a value explicitly.'; | ||
| } else { | ||
| $message = 'Cannot autowire service "%s": argument "%s$%s" of method "%s()" must have a type-hint or be given a value explicitly.'; |
There was a problem hiding this comment.
just adding a type hint does not neccessarily help like string. So maybe it should say something like "must have a known type-hint".
3f4217a to
d9215f7
Compare
|
message updated |
d9215f7 to
607f54f
Compare
Tobion
reviewed
Apr 9, 2018
| @@ -233,7 +233,10 @@ private function autowireMethod(\ReflectionFunctionAbstract $reflectionMethod, a | |||
| if ($parameter->isOptional()) { | |||
| continue; | |||
| } | |||
| throw new AutowiringFailedException($this->currentId, sprintf('Cannot autowire service "%s": argument "$%s" of method "%s()" must have a type-hint or be given a value explicitly.', $this->currentId, $parameter->name, $class !== $this->currentId ? $class.'::'.$method : $method)); | |||
| $type = ProxyHelper::getTypeHint($reflectionMethod, $parameter, false); | |||
| $type = $type ? sprintf('is type-hinted "%s"', $type) : 'has not type-hint'; | |||
607f54f to
1c9e5f3
Compare
Tobion
approved these changes
Apr 9, 2018
1c9e5f3 to
7f39811
Compare
stof
approved these changes
Apr 10, 2018
|
Thank you @nicolas-grekas. |
Tobion
added a commit
that referenced
this pull request
Apr 10, 2018
…gument (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Improve error message for non-autowirable scalar argument | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26838 | License | MIT | Doc PR | - Commits ------- 7f39811 [DI] Improve error message for non-autowirable scalar argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.