Add d-block to bootstrap 4 alerts #26870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normisg
commented
Apr 9, 2018
•
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #26869 |
| License | MIT |
| Doc PR | N/A |
…alar argument (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Improve error message for non-autowirable scalar argument | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#26838 | License | MIT | Doc PR | - Commits ------- 7f39811 [DI] Improve error message for non-autowirable scalar argument
|
Is there any reason why a https://getbootstrap.com/docs/4.0/components/alerts/ Using |
|
Yes, it was changed in 5dcaaad to "Make sure form errors is valid HTML". |
|
The reason for this is that now error blocks might appear inside |
vudaltsov
suggested changes
Apr 11, 2018
| @@ -283,7 +283,7 @@ | |||
|
|
|||
| {% block form_errors -%} | |||
| {%- if errors|length > 0 -%} | |||
| <span class="{% if form is not rootform %}invalid-feedback d-block{% else %}alert alert-danger{% endif %}"> | |||
| <span class="{% if form is not rootform %}invalid-feedback d-block{% else %}alert alert-danger d-block{% endif %}"> | |||
There was a problem hiding this comment.
Let's move the d-block class outside the {% if %} statement to have it only once in the line
…ns in tests (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Dont create mock cookie for new sessions in tests | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#26493 | License | MIT | Doc PR | - @romainneutron can you please check if this fixes your issue? Commits ------- 86b850e [HttpKernel] Dont create mock cookie for new sessions in tests
2dfb071 to
40bd8bd
Compare
|
Thank you @normisg. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 14, 2018
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #26870). Discussion ---------- Add d-block to bootstrap 4 alerts | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26869 | License | MIT | Doc PR | N/A Commits ------- 40bd8bd Add d-block to bootstrap 4 alerts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.