Skip to content

[Console] Fix PSR exception context key #26959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

scaytrase
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26957
License MIT
Doc PR None

Fixes context key according to PSR-3
cc. @xabbuh

@chalasr
Copy link
Member

chalasr commented Apr 17, 2018

Tests need to be updated https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Console/Tests/EventListener/ErrorListenerTest.php

@nicolas-grekas nicolas-grekas changed the title Fix PSR exception context key [Console] Fix PSR exception context key Apr 17, 2018
@scaytrase scaytrase force-pushed the bugfix/fix-console-psr-context branch from d103bd1 to a28393e Compare April 17, 2018 09:32
@scaytrase
Copy link
Contributor Author

Updated the test

@fabpot
Copy link
Member

fabpot commented Apr 17, 2018

Thank you @scaytrase.

@fabpot fabpot merged commit a28393e into symfony:3.4 Apr 17, 2018
fabpot added a commit that referenced this pull request Apr 17, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

[Console] Fix PSR exception context key

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26957
| License       | MIT
| Doc PR        | None

Fixes context key according to PSR-3
cc. @xabbuh

Commits
-------

a28393e Fix PSR exception context key
@scaytrase scaytrase deleted the bugfix/fix-console-psr-context branch April 17, 2018 11:24
This was referenced Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants