I think there will be a similar number of pros and cons.
Should we add TwigFunction by analogy with dump 🤔

Seeing dd() anywhere in the code for the first time would cause nothing else but confusion. If one wants to save keystrokes, why not create a macro in IDE (or use a debugger)?

• It doesn't add complexity
• It's optional
• It's faster than hooking up the debugger
• Not everyone has experience with a debugger
• It doesn't replace a debugger and you're not forced to use this

I see no downsides and maintenance isn't an issue 👍

@iltar But you have dump(), as @pamil said you can create IDE macro. If this gets accepted won't it start an avalanche of people wanting shortcuts for something?

Creating a macro in the IDE is part of the doc, not the framework, and not asked as much as dd(). I'm totally approving this feature as it's almost like "everyone's asking for it", where debugger usage, even though better, can be cumbersome for lots of devs.

@kunicmarko20 Not everyone is always developing with an IDE, don't forget the notepad(++), Vim, atom etc developers. Also important to note down, is that the var-dumper can be used as stand-alone. Meaning if devs like the symfony dump(), they can use this package. This reaches far beyond experienced developers with debuggers, as you'll probably be reaching hobby devs, wordpress/joomla/drupal devs etc.

When you're comparing the full feature set of the var-dumper component vs other dumpers, then a dump and die functionality is quite common and desired. It takes a few lines to add the function, but adds a big feeling of completion for the developers that would otherwise have used a dd()-similar function from another framework.

I think it's quite nice to have a "full" solution coming from Symfony, making it even better 👍

After reading the reasoning behind introducing this function I think it's a good idea in fact and with almost no potential for harm. 👍

The feature itself is must have, but not sure about name, confuses a bit.

@iltar Can you explain "It's optional"? What if I want dump() but not dd() in global scope?

@nicolas-grekas @DojoGeekRA chrome 65 removed the need for an error code to render the preview that was introduced with 62 https://bugs.chromium.org/p/chromium/issues/detail?id=785050

Why not add an optional argument to dump() to exit when it's done instead of creating a whole new function?

Why not add an optional argument to dump() to exit when it's done instead of creating a whole new function?

because dump is variadic

@lyrixx Ah, good point.

Oh, a enem..., erm, a friend @taylorotwell here? Hey, let's drink coffee?

About function, I think that is best to be more verbosity, how dump_die, dump_exit or dump_output as example, what you think guys?

Why not add an optional argument to dump() to exit when it's done instead of creating a whole new function?

Because dump today support multiple arguments.

If people think we need a shortcut then it should be small, dd is the best choice for this. If it is longer then I can write dump();die(); myself.

What a mess of a conversation just for a DX initiative that has been demanded for a long time, and still lots of arguments against.

I think this is part of the small changes that can really conciliate lots of dev communities and improve "classic" debug experience as well for people not using complex xdebug setups or full-stack IDEs. I mean, when one debugs using VIM, a simple dd() is really straightforward.

+1 for dump_die()

Maybe rename Symfony\Component\VarDumper\VarDumper::dump() to D::d() instead?

I don't miss a dd() shortcut but I can barely think of any serious objection. The proposed name is convenient and matches other frameworks, so I'd stick with it.

Thank you @nicolas-grekas.

@Pierstoval

I mean, when one debugs using VIM, a simple dd() is really straightforward.

Unless they're in command mode 😂

Lets be clear, a function/method/class should always have a name that describes it's purpose, it helps the developers and prevents mistakes.

dd, a or Foobar are not descriptive (unless you have a Bar named foo - insert Jonh Taffer meme here ) but it's important to understand why we use these undescriptive names, because it doesn't matter. Foobar is only used as an example for testing, dd() is something you only use during development!! It prints the result and stops execution, please don't tell me your production does this kind of logic 😐 (you properly use a proper solution for a specific problem and let the framework handle exceptions and the response handling).

Clean Code is about production code and tests, not about simple hacks to find out why something isn't working. Not everyone has the power of a debugger, sometimes the debugger is not able to reach the code (actually happened to me a few time) or doesn't show all details (or the details are to verbose), by using the VarDumper you can easily solve this problem, and having a simple method to dump and prevent further execution is perfectly fine for development and troubleshooting.

Good job! Thanks @nicolas-grekas

👍

I'm locking the thread because the issue has been resolved.
Thank you all for participating!