[TwigBridge] [Bootstrap 4] Fix PercentType error rendering. #26983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the 3.4 branch. Discussion ---------- [Cache] Inline some hot function calls | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The Cache component is typically found in critical code paths, let's inline some calls. I didn't change all calls but only those in potential hot paths. Submitted against 3.4 to reduce future merge conflicts. The PR also embeds edge-case behavior fixes for `ChainAdapter`. Commits ------- 52b4bfc [Cache] Inline some hot function calls
|
That's for 3.4. |
xabbuh
approved these changes
Apr 20, 2018
Nyholm
approved these changes
Apr 20, 2018
There was a problem hiding this comment.
Thank you.
Here is a reference to the Bootstrap docs that shows that this PR is valid: https://getbootstrap.com/docs/4.0/components/forms/#server-side
Im 👍
|
Thank you @alexismarquis. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 20, 2018
…. (alexismarquis) This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes #26983). Discussion ---------- [TwigBridge] [Bootstrap 4] Fix PercentType error rendering. | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | / | License | MIT | Doc PR | / Fixes displaying errors for Symfony\Component\Form\Extension\Core\Type\PercentType, as shown in the following screenshots : **Before :**  **After :**  Commits ------- 4715397 Fix PercentType error rendering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes displaying errors for Symfony\Component\Form\Extension\Core\Type\PercentType, as shown in the following screenshots :
Before :
After :
