[DI] Add check of internal type to ContainerBuilder::getReflectionClass #27025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
requested changes
Apr 24, 2018
| @@ -321,6 +321,11 @@ public function getReflectionClass(?string $class, bool $throw = true): ?\Reflec | |||
| if (!$class = $this->getParameterBag()->resolveValue($class)) { | |||
| return null; | |||
| } | |||
|
|
|||
| if ($this->isInternalType($class)) { | |||
There was a problem hiding this comment.
I'd suggest to use a private static array instead, and put types as keys in the array, so that checking could be done inline with a simple isset()
There was a problem hiding this comment.
Oh, you are right. It would be much better.
| 'array', | ||
| 'null', | ||
| 'callable', | ||
| 'iterable', |
There was a problem hiding this comment.
I'd suggest to add "mixed" to the list: even if it's not an official one, it's pretty common in phpdoc so might be OK to use it here also
There was a problem hiding this comment.
After some reflections I agree with you :)
9964403 to
8c3c060
Compare
chalasr
approved these changes
Apr 24, 2018
stof
approved these changes
Apr 24, 2018
|
Thank you @upyx. |
stof
added a commit
that referenced
this pull request
Apr 24, 2018
…flectionClass (upyx) This PR was submitted for the 4.0 branch but it was merged into the 3.4 branch instead (closes #27025). Discussion ---------- [DI] Add check of internal type to ContainerBuilder::getReflectionClass | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27018 | License | MIT | Doc PR | no This PR fixes bug described in #27018 issue. I think that `getReflectionClass` should return `NULL` when internal type was used instead class name but not throws exception. As well as it does when class is empty. If someone have other opinion we can discuss it. Commits ------- 314e881 [DI] Add check of internal type to ContainerBuilder::getReflectionClass
|
Thank you for your review! |
|
Congratz for your first contribution to Symfony @upyx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes bug described in #27018 issue.
I think that
getReflectionClassshould returnNULLwhen internal type was used instead class name but not throws exception. As well as it does when class is empty. If someone have other opinion we can discuss it.