[Security] Skip user checks if not implementing UserInterface #27044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Apr 25, 2018
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #26871 |
| License | MIT |
| Doc PR | n/a |
stof
requested changes
Apr 25, 2018
| @@ -44,6 +45,10 @@ public function authenticate(TokenInterface $token) | |||
| throw new AuthenticationException('Simple authenticator failed to return an authenticated token.'); | |||
| } | |||
|
|
|||
| if ($authToken instanceof AnonymousToken) { | |||
There was a problem hiding this comment.
the right check would be !$user instanceof UserInterface, to cover all cases where calling the user checker is not possible.
758860f to
fa20fe1
Compare
fa20fe1 to
384acf9
Compare
nicolas-grekas
approved these changes
Apr 25, 2018
aschempp
approved these changes
Apr 25, 2018
fabpot
approved these changes
Apr 25, 2018
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Apr 25, 2018
…ace (chalasr) This PR was merged into the 2.7 branch. Discussion ---------- [Security] Skip user checks if not implementing UserInterface | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26871 | License | MIT | Doc PR | n/a Commits ------- 384acf9 [Security] Skip user checks if not implementing UserInterface
|
It seems that the changes have not been merged correctly into the 2.8 branch (and higher). I can confirm that the error no longer occurs in version 2.7, however, it still does occur in the versions 2.8, 3.4 and 4.0. |
|
But tests pass, so there is a missing test case. |
|
I can see what happened, I'm on it |
|
Here you go: #27059 |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 26, 2018
… (leofeyer) This PR was merged into the 2.8 branch. Discussion ---------- Make the simple auth provider the same as in Symfony 2.7 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27044 | License | MIT This PR adds the `SimpleAuthenticationProvider` changes made in Symfony 2.7 to Symfony 2.8. See #27044 (comment) Commits ------- 9afad9d Make the simple auth provider the same as in Symfony 2.7.
Merged
This was referenced Apr 30, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.