[HttpKernel] Don't clean legacy containers that are still loaded #27061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Apr 26, 2018
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #27053 |
| License | MIT |
| Doc PR | - |
chalasr
approved these changes
Apr 26, 2018
sroze
approved these changes
Apr 26, 2018
stof
approved these changes
Apr 26, 2018
lyrixx
reviewed
Apr 26, 2018
| if ($oldContainerDir.'.legacy' !== $legacyContainer && @unlink($legacyContainer)) { | ||
| (new Filesystem())->remove(substr($legacyContainer, 0, -7)); | ||
| } | ||
| } | ||
|
|
||
| touch($oldContainerDir.'.legacy'); | ||
| file_put_contents($oldContainerDir.'.legacy', $oldContainer->name); |
There was a problem hiding this comment.
Maybe you should append to the file ?
There was a problem hiding this comment.
Not sure what you mean. There is one legacy file per legacy container.
Anyway, I completely changed the implementation.
No extra IO is required as a static array can do the job :)
586dbec to
be8dbc3
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Apr 26, 2018
…loaded (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Don't clean legacy containers that are still loaded | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27053 | License | MIT | Doc PR | - Commits ------- be8dbc3 [HttpKernel] Don't clean legacy containers that are still loaded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.