[DI][Routing] Allow invokable objects to be used as PHP-DSL loaders #27065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks :) |
|
For which case? When tried to supply array callback? Because when array would be passed nothing will happen so I don't know what to test against. |
|
For the case when you pass an invokable object. |
|
Oh right forgot about this simple case 😊 |
|
@nicolas-grekas I don't know about Routing test I did not want to introduce copied test case so I just extended existing test case there. |
nicolas-grekas
approved these changes
Apr 26, 2018
This was referenced Apr 26, 2018
Tobion
reviewed
Apr 26, 2018
| @@ -0,0 +1,10 @@ | |||
|
|
|||
There was a problem hiding this comment.
Tobion
approved these changes
Apr 26, 2018
fabpot
approved these changes
Apr 27, 2018
|
Thank you @aurimasniekis. |
fabpot
added a commit
that referenced
this pull request
Apr 27, 2018
…P-DSL loaders (aurimasniekis) This PR was squashed before being merged into the 4.1-dev branch (closes #27065). Discussion ---------- [DI][Routing] Allow invokable objects to be used as PHP-DSL loaders | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26583, #25630 | License | MIT | Doc PR | none Changed DI/Router PHPFileLoader to check is_object && is_callable instead of instance of Closure Commits ------- 662ff7e [DI][Routing] Allow invokable objects to be used as PHP-DSL loaders
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed DI/Router PHPFileLoader to check is_object && is_callable instead of instance of Closure