[PHPUnitBridge] Add an implementation just for php 7.0 #27086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
php 7 does not have the void return type.
|
@juliendufresne @nicolas-grekas please review |
greg0ire
commented
Apr 29, 2018
| @@ -24,7 +24,7 @@ class TestRunnerForV6 extends BaseRunner | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| protected function handleConfiguration(array &$arguments): void | |||
| protected function handleConfiguration(array &$arguments) | |||
There was a problem hiding this comment.
The existing runner looses its void return type, but keeps the code changes (doesn't return anything, extends from PHPUnit\TextUI\TestRunner)
greg0ire
commented
Apr 29, 2018
| * | ||
| * @internal | ||
| */ | ||
| class TestRunnerForV7 extends BaseRunner |
There was a problem hiding this comment.
This one is the former TestRunnerForV6, renamed
nicolas-grekas
approved these changes
Apr 29, 2018
juliendufresne
approved these changes
Apr 29, 2018
|
Thank you @greg0ire. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 30, 2018
…eg0ire) This PR was merged into the 3.4 branch. Discussion ---------- [PHPUnitBridge] Add an implementation just for php 7.0 | Q | A | ------------- | --- | Branch? | 3.4, because the bug only appears on that branch and up | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> php 7 does not have the void return type, which means we have to have a specific class for the php 7.0 + phpunit 6 combination. Commits ------- fc69307 Add an implementation just for php 7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php 7 does not have the void return type, which means we have to have a specific class for the php 7.0 + phpunit 6 combination.