[Cache] fix logic for fetching tag versions on TagAwareAdapter #27158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| if (!isset($this->knownTagVersions[$tag])) { | ||
| $fetchTagVersions = true; |
There was a problem hiding this comment.
That's the correct fix thanks. I'd just suggest to keep the previous single "if" and add this line in it.
nicolas-grekas
approved these changes
May 4, 2018
82e3ab9 to
d3790ca
Compare
|
Thank you @dmaicher. |
nicolas-grekas
added a commit
that referenced
this pull request
May 5, 2018
…pter (dmaicher) This PR was squashed before being merged into the 3.4 branch (closes #27158). Discussion ---------- [Cache] fix logic for fetching tag versions on TagAwareAdapter | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27147 | License | MIT | Doc PR | - There was a problem introduced in #27007 which breaks tag invalidation. From what I can see there were some cases when the actual tag versions were never fetched from the tags pool and version=0 was used. @nicolas-grekas this is my attempt of understanding the logic within `TagAwareAdapter`. Please have a look if this makes sense to you 😉 Commits ------- d3790ca [Cache] fix logic for fetching tag versions on TagAwareAdapter
|
@nicolas-grekas Any chance getting a small 3.4 release out? |
This was referenced May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem introduced in #27007 which breaks tag invalidation.
From what I can see there were some cases when the actual tag versions were never fetched from the tags pool and version=0 was used.
@nicolas-grekas this is my attempt of understanding the logic within
TagAwareAdapter. Please have a look if this makes sense to you 😉