Skip to content

[FrameworkBundle][Messenger] Remove convention-based service id generation for buses #27162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2018

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented May 4, 2018

Q A
Branch? master
Bug fix? yes (DX)
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Service ids for buses are user facing ids: ppl will have to deal with them when wiring their services.
Like for cache pools, we should ask ppl to declare them using full identifiers, instead of having a convention-based way to turn a name into and id (which is something nobody will be able to remember at some point.)

@fabpot
Copy link
Member

fabpot commented May 7, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit c7a0045 into symfony:master May 7, 2018
fabpot added a commit that referenced this pull request May 7, 2018
…ce id generation for buses (nicolas-grekas)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[FrameworkBundle][Messenger] Remove convention-based service id generation for buses

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes (DX)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Service ids for buses are user facing ids: ppl *will* have to deal with them when wiring their services.
Like for cache pools, we should ask ppl to declare them using full identifiers, instead of having a convention-based way to turn a name into and id (which is something nobody will be able to remember at some point.)

Commits
-------

c7a0045 [FrameworkBundle][Messenger] Remove convention-based service id generation for buses
fabpot added a commit that referenced this pull request May 9, 2018
This PR was merged into the 4.1 branch.

Discussion
----------

[Messenger] Fix default bus name

| Q             | A
| ------------- | ---
| Branch?       | 4.1 <!-- see below -->
| Bug fix?      | yesish
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #27162   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

After #27162, the default bus name configured automatically should use a full service id too, otherwise we currently get a `default` service id, no namespace identifier, which is the default bus.

Commits
-------

fa9b984 [Messenger] Fix default bus name
weaverryan added a commit to symfony/symfony-docs that referenced this pull request May 9, 2018
This PR was submitted for the master branch but it was squashed and merged into the 4.1 branch instead (closes #9727).

Discussion
----------

[Messenger] Update the messenger documentation

- [x] Fixes #9641 with the middleware configuration.
- [x] Fixes #9617 with the multiple bus configuration.
- [x] Change adapters to transports (waiting merge: symfony/symfony#27129)
- [x] middlewares config entry is renamed middleware (symfony/symfony#27177)
- [x] in the config, message buses names are the full service id you'll use (symfony/symfony#27162)
- [x] Add TransportInterface as first class citizen sender+receiver (symfony/symfony#27164)

Commits
-------

c3c3528 Few updates following review
64bfd75 Change wording and don't use `.`-based services so it's just clearer
e1f3b5a Fix the formating of the method name
9b7b85f Update the example of using multiple buses to use DI's `bind`s
c76b2c2 Uses the full service name when configuring the buses from the YAML configuration
2409798 Middleware does not have a plural
a20286d Add a note about the symfony serializer pack
10f46eb Introduce the `TransportInterface`
ef70bc0 Add a documentation about the middlewares
3ff8cfe Add multiple buses configuration and type-hint example
a4bc592 Rename the adapters to transport
@nicolas-grekas nicolas-grekas deleted the messenger-explicit branch May 16, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants