[Messenger] Re-introduce wrapped message configuration (with fix) #27182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a9d672 to
ad01c29
Compare
ogizanagi
approved these changes
May 7, 2018
|
What exactly was the bug? |
|
The original envelope was not properly passed along the whole middleware stack when calling |
|
I've pushed another commit to sroze#6 for the TraceableBus which misses a small update. |
837c483 to
b879e1d
Compare
…ispatching (ogizanagi) This reverts commit 76b17b0.
Ensure that the middlewares can also update the message within the envelope
b879e1d to
21e49d2
Compare
|
Merging as we found and fixed the bug that was almost to bug in beta1. |
|
Thank you @ogizanagi. |
sroze
added a commit
that referenced
this pull request
May 9, 2018
… (with fix) (sroze, ogizanagi) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Re-introduce wrapped message configuration (with fix) | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26945 | License | MIT | Doc PR | ø The pull request was merged before beta1, but because it introduced a bug, it has been reverted. This adds back the merged PR but pushes a fix for the found bug. Commits ------- 21e49d2 [Messenger] Fix TraceableBus with envelope 599f32c Ensure the envelope is passed back and can be altered Ensure that the middlewares can also update the message within the envelope 7c33cb2 feature #26945 [Messenger] Support configuring messages when dispatching (ogizanagi)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request was merged before beta1, but because it introduced a bug, it has been reverted. This adds back the merged PR but pushes a fix for the found bug.