Skip to content

Conversation

tarlepp
Copy link
Contributor

@tarlepp tarlepp commented May 7, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets
License MIT
Doc PR symfony/symfony-docs#...

Note that tests that are failing are not related to this component.

@nicolas-grekas nicolas-grekas changed the base branch from master to 2.7 May 7, 2018 18:39
@nicolas-grekas
Copy link
Member

Thank you @tarlepp.

@nicolas-grekas nicolas-grekas merged commit 5539f9d into symfony:2.7 May 7, 2018
nicolas-grekas added a commit that referenced this pull request May 7, 2018
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #27183).

Discussion
----------

Fixed return type

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | no    <!-- please add some, will be required by reviewers -->
| Fixed tickets |    <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->
Note that tests that are failing are not related to this component.

Commits
-------

5539f9d Fixed return type
@tarlepp tarlepp deleted the patch-1 branch May 8, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants