[DI] Display previous error messages when throwing unused bindings #27191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvasseur
suggested changes
May 8, 2018
| throw new InvalidArgumentException(sprintf('Unused binding "%s" in service "%s".', $key, $serviceId)); | ||
| $message = sprintf('Unused binding "%s" in service "%s".', $key, $serviceId); | ||
| if ($this->errors) { | ||
| $message .= sprintf("\nCould be related to%s:", 1 < \count($errors) ? ' one of' : ''); |
There was a problem hiding this comment.
This should be $this->errors
| if ($this->errors) { | ||
| $message .= sprintf("\nCould be related to%s:", 1 < \count($errors) ? ' one of' : ''); | ||
| } | ||
| foreach ($this->errors as $serviceId => $mesage) { |
There was a problem hiding this comment.
Not sure if the missing s is voluntary here, but we can't use $message since it's used in the parent scope, maybe $error ?
| $message .= sprintf("\nCould be related to%s:", 1 < \count($errors) ? ' one of' : ''); | ||
| } | ||
| foreach ($this->errors as $serviceId => $mesage) { | ||
| $message .= sprintf("\n - \"%s\": %s", $serviceId, $message); |
There was a problem hiding this comment.
I don't think we need to put the service id here since it's already in the exception message thrown by getConstructor.
|
Thank you @jvasseur, comments addressed. Do you confirm it fixes your issue? |
6d5d18a to
40fe7cd
Compare
jvasseur
approved these changes
May 9, 2018
|
@nicolas-grekas could you add a test for that? |
|
Test added. |
40fe7cd to
f2231b5
Compare
sroze
approved these changes
May 9, 2018
fabpot
approved these changes
May 12, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
May 12, 2018
…bindings (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Display previous error messages when throwing unused bindings | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | n | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27146 | License | MIT | Doc PR | - As reported by @jvasseur, confirmation + review welcome. Commits ------- f2231b5 [DI] Display previous error messages when throwing unused bindings
This was referenced May 21, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @jvasseur, confirmation + review welcome.