[Messenger] Fix AMQP Transport factory & TransportFactoryInterface #27197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also other here #27196 |
sroze
approved these changes
May 8, 2018
|
Let's add more of an integration test, we should have caught that. Will do in a following PR... |
|
You were fast on this one, thanks @ogizanagi. |
sroze
added a commit
that referenced
this pull request
May 8, 2018
…nterface (ogizanagi) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Fix AMQP Transport factory & TransportFactoryInterface | Q | A | ------------- | --- | Branch? | 4.1 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #27164 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Seems like we did review a bit fast here 😅 Commits ------- 98967cd [Messenger] Fix AMQP Transport factory & TransportFactoryInterface
sroze
added a commit
that referenced
this pull request
May 10, 2018
…oze) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Add more tests around the AMQP transport | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | ø Adding more tests to the AMQP transport/factory. These should have captured the following 3 bugs: #27198, #27197, #27196. Commits ------- faf9382 Add more tests around the AMQP transport
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like we did review a bit fast here 😅