[Messenger] Make sure default receiver name is set before command configuration #27224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
suggested changes
May 10, 2018
9d35f00 to
266c273
Compare
|
Status: Needs Review |
266c273 to
95ddd4f
Compare
nicolas-grekas
approved these changes
May 10, 2018
sroze
approved these changes
May 10, 2018
ogizanagi
approved these changes
May 11, 2018
95ddd4f to
63871c9
Compare
|
Thank you @yceruto. |
sroze
added a commit
that referenced
this pull request
May 11, 2018
…command configuration (yceruto) This PR was squashed before being merged into the 4.1 branch (closes #27224). Discussion ---------- [Messenger] Make sure default receiver name is set before command configuration | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27203 | License | MIT | Doc PR | - Otherwise the receiver's name would still be required always. https://github.com/symfony/symfony/blob/3cc4a701e6f24cb2eaaf1234b331f182dea0c9b4/src/Symfony/Component/Console/Command/Command.php#L77 Commits ------- 63871c9 [Messenger] Make sure default receiver name is set before command configuration
sroze
added a commit
that referenced
this pull request
May 17, 2018
…g or typo (yceruto) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Select alternatives on missing receiver arg or typo | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - If there is more than one receiver available - `bin/console messenger:consume-messages`:  If typo and there is similarities - `bin/console messenger:consume-messages amq`:  requires #27224 Commits ------- 54c2541 Select alternatives on missing receiver arg or typo
symfony-splitter
pushed a commit
to symfony/messenger
that referenced
this pull request
May 17, 2018
…g or typo (yceruto) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Select alternatives on missing receiver arg or typo | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - If there is more than one receiver available - `bin/console messenger:consume-messages`:  If typo and there is similarities - `bin/console messenger:consume-messages amq`:  requires symfony/symfony#27224 Commits ------- 54c2541d94 Select alternatives on missing receiver arg or typo
Merged
symfony-splitter
pushed a commit
to symfony/messenger
that referenced
this pull request
Jan 28, 2020
…g or typo (yceruto) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Select alternatives on missing receiver arg or typo | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - If there is more than one receiver available - `bin/console messenger:consume-messages`:  If typo and there is similarities - `bin/console messenger:consume-messages amq`:  requires symfony/symfony#27224 Commits ------- 54c2541d94 Select alternatives on missing receiver arg or typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the receiver's name would still be required always.
symfony/src/Symfony/Component/Console/Command/Command.php
Line 77 in 3cc4a70