[FrameworkBundle] Fix cache:clear on vagrant #27231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
approved these changes
May 11, 2018
fabpot
requested changes
May 11, 2018
| $fs->rename($oldCacheDir.'/'.$containerDir, $realCacheDir.'/'.$containerDir); | ||
| touch($realCacheDir.'/'.$containerDir.'.legacy'); | ||
| if (0 === strpos($realCacheDir, $mount)) { | ||
| $io->note('For better performances, you should move the cache/ and log/ directories to a non-shared folder of your vm.'); |
There was a problem hiding this comment.
log or logs depending on how you created the project (Flex vs SE)
There was a problem hiding this comment.
I removed the slash instead, to tell about the concept, not the actual dirs. Ok for you?
fabpot
approved these changes
May 11, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
May 11, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Fix cache:clear on vagrant | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27154 | License | MIT | Doc PR | - What a mess, shared folder on vbox...  Commits ------- 3381611 [FrameworkBundle] Fix cache:clear on vagrant
This was referenced May 21, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What a mess, shared folder on vbox...