[Validator] Use strict type in URL validator #27264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b61ac0e to
4b00265
Compare
|
I think the strict comparison should be added in the 3.4 branch already |
4b00265 to
2400e71
Compare
stof
approved these changes
May 14, 2018
ogizanagi
approved these changes
May 14, 2018
|
This is a BC break. Booleans are not relevant here, user can pass numeric strings. |
|
@ostrolucky |
|
I see. All good then! |
fabpot
approved these changes
May 18, 2018
|
Thank you @mimol91. |
fabpot
added a commit
that referenced
this pull request
May 18, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Use strict type in URL validator | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes Fixed tickets | - | License | MIT | Doc PR | - Using `checkDNS` option with value `true` generate error `Warning: checkdnsrr(): Type '1' not supported`. In SF 3.4 it was mark as depreciation and silently converted to `ANY` https://github.com/symfony/symfony/blob/v3.4.9/src/Symfony/Component/Validator/Constraints/UrlValidator.php#L79 ~~Test are failing on `Symfony\Component\HttpKernel\Tests\ControllerMetadata\ArgumentMetadataFactoryTest::testSignature1` - I think its not related~~ Commits ------- 2400e71 use strict compare in url validator
This was referenced May 21, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
checkDNSoption with valuetruegenerate errorWarning: checkdnsrr(): Type '1' not supported.In SF 3.4 it was mark as depreciation and silently converted to
ANYhttps://github.com/symfony/symfony/blob/v3.4.9/src/Symfony/Component/Validator/Constraints/UrlValidator.php#L79Test are failing onSymfony\Component\HttpKernel\Tests\ControllerMetadata\ArgumentMetadataFactoryTest::testSignature1- I think its not related