[DI] fine tune dumped factories #27268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
May 15, 2018
|
Can't we merge this in lower branches too? |
|
that's not a bugfix but an improvement, so that's for master |
ogizanagi
approved these changes
May 15, 2018
Tobion
reviewed
May 15, 2018
| continue; | ||
| } | ||
| $ids = array(); | ||
| foreach ($node->getInEdges() as $edge) { |
There was a problem hiding this comment.
I'd recommend to extract that whole logic into a new private method for clarity.
da466eb to
09314e1
Compare
| @@ -68,6 +69,7 @@ class PhpDumper extends Dumper | |||
| private $inlineRequires; | |||
| private $inlinedRequires = array(); | |||
| private $circularReferences = array(); | |||
| private $singlePrivateIds = array(); | |||
There was a problem hiding this comment.
Minor comment. I didn't like the $singlePrivateIds var name, so I looked for English words that mean "used once" and maybe it could be better to rename this to $singleUsePrivateIds
09314e1 to
0be8bf7
Compare
Tobion
reviewed
May 15, 2018
| @@ -1798,6 +1804,22 @@ private function isHotPath(Definition $definition) | |||
| return $this->hotPathTag && $definition->hasTag($this->hotPathTag) && !$definition->isDeprecated(); | |||
| } | |||
|
|
|||
| private function isSingleUsePrivateNode(ServiceReferenceGraphNode $node) | |||
There was a problem hiding this comment.
but OK on master :)
0be8bf7 to
88ecd0d
Compare
Tobion
approved these changes
May 16, 2018
fabpot
approved these changes
May 17, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
May 17, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [DI] fine tune dumped factories | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Here is an optimization we forgot in the dumped container: when a private service is referenced once, there is no need to keep it in the internal registry as it will never be reused. This should help a bit the garbage collection process. Commits ------- 88ecd0d [DI] fine tune dumped factories
This was referenced Nov 3, 2018
Closed
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 2, 2018
…services (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Fix dumping expressions accessing single-use private services | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29403 | License | MIT | Doc PR | n/a Introduced in #27268, see fixed ticket Commits ------- d1e84aa [DI] Fix dumping expressions accessing single-use private services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an optimization we forgot in the dumped container: when a private service is referenced once, there is no need to keep it in the internal registry as it will never be reused. This should help a bit the garbage collection process.