[Routing] Fix adding name prefix to canonical route names #27270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
May 15, 2018
| @@ -161,6 +161,11 @@ public function addNamePrefix(string $prefix) | |||
| $prefixedRoutes = array(); | |||
|
|
|||
| foreach ($this->routes as $name => $route) { | |||
| if (null !== $route->getDefault('_canonical_route')) { | |||
| $prefixedRouteName = $prefix.$route->getDefault('_canonical_route'); | |||
| $route->setDefault('_canonical_route', $prefixedRouteName); | |||
There was a problem hiding this comment.
I'd propose to move the added block after the line blow, doing this:
if (null !== $name = $route->getDefault('_canonical_route')) {
$route->setDefault('_canonical_route', $prefix.$name);
}There was a problem hiding this comment.
Thanks for your review, I updated code following your advice
nicolas-grekas
approved these changes
May 15, 2018
|
Thank you @ismail1432. |
fabpot
added a commit
that referenced
this pull request
May 17, 2018
…(ismail1432) This PR was merged into the 4.1 branch. Discussion ---------- [Routing] Fix adding name prefix to canonical route names | Q | A | ------------- | --- | Branch? | 4.1 for bug fixes <!-- see below --> | Bug fix? | yes | New feature? |no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #27244 <!-- #-prefixed issue number(s), if any --> | License | MIT This PR resolve the [bug](#27244) in the [prefix imported routes name](https://symfony.com/blog/new-in-symfony-4-1-prefix-imported-route-names) feature. Reviews are always welcomed moreover as I touch a key element ( the `_canonical_route` attribute ). I need an expert in the Routing component to avoid side effect Thanks Commits ------- cb5ce8f fix bug when imported routes are prefixed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolve the bug in the prefix imported routes name feature. Reviews are always welcomed moreover as I touch a key element ( the
_canonical_routeattribute ). I need an expert in the Routing component to avoid side effectThanks