[DI] Allow defining bindings on ChildDefinition #27271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b598882 to
1c3b105
Compare
|
The reason why we need to be able to put bindings there is because of autoconfiguration using ChildDefinition too (and doing this transformation early) |
stof
approved these changes
May 15, 2018
chalasr
approved these changes
May 15, 2018
ogizanagi
approved these changes
May 15, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
May 17, 2018
…rekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Allow defining bindings on ChildDefinition | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Spotted by @stof while trying to put symfony/monolog-bundle#254 into practice. Binding log channels doesn't work because we put this artificial restriction in place. Let's allow ChildDefinition to have bindings (but only at the DI extension level, loaders still forbid defining them at their level because of the parent vs _defaults ambiguity.) Commits ------- 1c3b105 [DI] Allow defining bindings on ChildDefinition
This was referenced May 21, 2018
Merged
Merged
Merged
fabpot
added a commit
to symfony/monolog-bundle
that referenced
this pull request
May 29, 2018
…ervices (stof) This PR was merged into the 3.x-dev branch. Discussion ---------- Fix the autowiring of the channel logger in autoconfigured services This depends on symfony/symfony#27271, hence the new min version of the DI component Commits ------- b39e571 Fix the autowiring of the channel logger in autoconfigured services
dani-danigm
pushed a commit
to dani-danigm/monolog-bundle
that referenced
this pull request
Jun 15, 2022
…ervices (stof) This PR was merged into the 3.x-dev branch. Discussion ---------- Fix the autowiring of the channel logger in autoconfigured services This depends on symfony/symfony#27271, hence the new min version of the DI component Commits ------- adcc0c2 Fix the autowiring of the channel logger in autoconfigured services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted by @stof while trying to put symfony/monolog-bundle#254 into practice.
Binding log channels doesn't work because we put this artificial restriction in place.
Let's allow ChildDefinition to have bindings (but only at the DI extension level, loaders still forbid defining them at their level because of the parent vs _defaults ambiguity.)