[Lock] Skip test if posix extension is not installed #27278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf1657e to
b4fbc6b
Compare
chalasr
reviewed
May 16, 2018
| @@ -35,6 +35,10 @@ | |||
| */ | |||
| public function testBlockingLocks() | |||
| { | |||
| if (!extension_loaded('posix')) { | |||
| $this->markTestSkipped('Extension posix is required.'); | |||
| } | |||
There was a problem hiding this comment.
* @requires extension posix in the docblock instead?
This isn't installed by default on Fedora
chalasr
approved these changes
May 16, 2018
stof
approved these changes
May 16, 2018
javiereguiluz
approved these changes
May 17, 2018
|
Thank you @ostrolucky. |
chalasr
pushed a commit
that referenced
this pull request
May 17, 2018
…trolucky) This PR was merged into the 3.4 branch. Discussion ---------- [Lock] Skip test if posix extension is not installed This isn't installed by default on Fedora | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- 97cbea0 [Lock] Skip test if posix extension is not installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't installed by default on Fedora