[Process] Consider "executable" suffixes first on Windows #27303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
May 18, 2018
xabbuh
reviewed
May 18, 2018
|
|
||
| $this->assertSamePath($target.'.BAT', $result); | ||
|
|
||
| unlink($target); |
There was a problem hiding this comment.
cleaning up the fragments should not only happen when the test succeeds
There was a problem hiding this comment.
Good point. How about now?
fabpot
approved these changes
May 27, 2018
|
Thank you @sanmai. |
fabpot
added a commit
that referenced
this pull request
May 27, 2018
…(sanmai) This PR was squashed before being merged into the 2.8 branch (closes #27303). Discussion ---------- [Process] Consider "executable" suffixes first on Windows | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | n/a Executable finder should consider "executable" suffixes first on Windows because we basically ignore executability on Windows (on the lines below changed), which leads, for example, to finding usually-non-executable `phpunit` file first where both `phpunit` and `phpunit.bat` are present. I may miss something here, so please tell me if this makes any sense. Same change against master: #27301 Commits ------- 9372e7a [Process] Consider \"executable\" suffixes first on Windows
This was referenced Jun 25, 2018
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executable finder should consider "executable" suffixes first on Windows because we basically ignore executability on Windows (on the lines below changed), which leads, for example, to finding usually-non-executable
phpunitfile first where bothphpunitandphpunit.batare present.I may miss something here, so please tell me if this makes any sense.
Same change against master: #27301