[PropertyInfo] Auto-enable PropertyInfo component #27429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be fair, this could even be considered as a bug and added from 3.4. WDYT? |
|
There is a test that ensures that property info is disabled by default. Did I miss something or should I remove it? |
dunglas
approved these changes
May 30, 2018
fabpot
approved these changes
May 30, 2018
|
(removed the test that forces the property info to be disabled) |
|
AppVeyor's failure is unrelated. |
e9e36a5 to
06ea72e
Compare
|
Thank you @sroze. |
fabpot
added a commit
that referenced
this pull request
May 31, 2018
This PR was squashed before being merged into the 4.2-dev branch (closes #27429). Discussion ---------- [PropertyInfo] Auto-enable PropertyInfo component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | ø The PropertyInfo component (used by the Serializer to provide more insights from PhpDocs, etc...) is disabled by default, not sure why. This enables it by default when the component is installed. Commits ------- 06ea72e [PropertyInfo] Auto-enable PropertyInfo component
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PropertyInfo component (used by the Serializer to provide more insights from PhpDocs, etc...) is disabled by default, not sure why. This enables it by default when the component is installed.