[PropertyInfo] Add an alias to the property info type extractor #27430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should do it for all specific interfaces then, right? |
45e9ac5 to
bbbcd46
Compare
|
@dunglas good point; added them 👍 |
dunglas
approved these changes
May 30, 2018
ogizanagi
approved these changes
May 30, 2018
|
Thank you @sroze. |
fabpot
approved these changes
May 31, 2018
fabpot
added a commit
that referenced
this pull request
May 31, 2018
…extractor (sroze) This PR was merged into the 4.2-dev branch. Discussion ---------- [PropertyInfo] Add an alias to the property info type extractor | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27139 | License | MIT | Doc PR | ø As spotted in #27139, we only alias the main PropertyInfo interface but we don't alias the other one, gathering only the types (while we implement it). This fixes the "problem" of auto-wiring it. Commits ------- bbbcd46 Add an alias to the property info type extractor
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted in #27139, we only alias the main PropertyInfo interface but we don't alias the other one, gathering only the types (while we implement it). This fixes the "problem" of auto-wiring it.