[Console] Add support for error ouput in the CommandTester #27434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
requested changes
Jun 6, 2018
| @@ -1,6 +1,11 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| 4.1.1 | |||
There was a problem hiding this comment.
4.2.0, new features are for minor releases
| @@ -91,6 +117,53 @@ public function setInputs(array $inputs) | |||
| return $this; | |||
| } | |||
|
|
|||
| /** | |||
| * Initialize the output property. | |||
There was a problem hiding this comment.
this comment is still relevant, we use the 3rd person form to describe methods
| $tester->run(array( | ||
| 'command' => 'foo', | ||
| 'foo' => 'bar', | ||
| ), |
| * | ||
| * @param array $options An array of options | ||
| * | ||
| * @return self |
There was a problem hiding this comment.
this one is not true and returning void is fine. Both @param and @return annotations should be removed as they do not provide any information that is not already provided by the method signature.
OskarStark
reviewed
Jun 11, 2018
| @@ -42,6 +41,7 @@ public function __construct(Command $command) | |||
| * * interactive: Sets the input interactive flag | |||
| * * decorated: Sets the output decorated flag | |||
| * * verbosity: Sets the output verbosity flag | |||
| * * capture_stderr_separately: Make output of stdOut and stdErr separately available | |||
cdekok
added a commit
to cdekok/symfony
that referenced
this pull request
Jun 12, 2018
chalasr
requested changes
Sep 5, 2018
src/Symfony/Component/Console/Tests/Tester/ApplicationTesterTest.php
Outdated
Show resolved
Hide resolved
35d41c6 to
8a076d1
Compare
8a076d1 to
cec5317
Compare
chalasr
approved these changes
Sep 23, 2018
|
Nice first contribution! Thank you @cdekok |
chalasr
pushed a commit
that referenced
this pull request
Sep 23, 2018
…ster (cdekok) This PR was merged into the 4.2-dev branch. Discussion ---------- [Console] Add support for error ouput in the CommandTester Move initialization of the streams to the trait so the `capture_stderr_separately` also works in the CommandTester. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27422 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Make it possible to test seperate stderr output. ```$tester = new CommandTester($command); $tester->execute( array('foo' => 'bar'), array('capture_stderr_separately' => true) ); $this->assertEquals('foo', $tester->getErrorOutput()); ```` Commits ------- cec5317 [Console] Add support for error ouput in the CommandTester
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move initialization of the streams to the trait so the
capture_stderr_separatelyalso works in the CommandTester.Make it possible to test seperate stderr output.