[Serializer] Allow to pass a single value for the groups opt #27503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huge 👍 because the previous |
Simperfit
approved these changes
Jun 5, 2018
|
Travis failure not related. |
lyrixx
approved these changes
Jun 5, 2018
ogizanagi
approved these changes
Jun 5, 2018
Pierstoval
approved these changes
Jun 6, 2018
fabpot
approved these changes
Jun 10, 2018
| if (isset($context[static::GROUPS]) && \is_array($context[static::GROUPS])) { | ||
| $groups = $context[static::GROUPS]; | ||
| if (isset($context[static::GROUPS])) { | ||
| $groups = (array) $context[static::GROUPS]; |
There was a problem hiding this comment.
shouldn't this check is_scalar||is_array instead of casting objects?
b7e8a89 to
5b39203
Compare
sroze
approved these changes
Jun 30, 2018
|
Thank you @dunglas. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 1, 2018
…ps opt (dunglas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Serializer] Allow to pass a single value for the groups opt | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | n/a | License | MIT | Doc PR | todo Shortcut syntax similar to #20509 but for the context: allows to pass a string instead of an array of string in the serialization context when only one group if used. Before: ```php $serializer->serialize($foo, 'json', ['groups' => ['myGroup']]; /** @ApiResource(normalizationContext={"groups"={"myGroup"}}) */ ``` After: ```php $serializer->serialize($foo, 'json', ['groups' => 'myGroup']; /** @ApiResource(normalizationContext={"groups"="myGroup") */ ``` Commits ------- 5b39203 [Serializer] Allow to pass a single value for the groups opt
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 11, 2018
… opt (dunglas, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [Serializer] Allow to pass a single value for the groups opt symfony/symfony#27503 Commits ------- ae558f4 Added the missing versionadded directive e4eae25 Replaced a "note" by a "tip" 5e0a91e [Serializer] Allow to pass a single value for the groups opt
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortcut syntax similar to #20509 but for the context: allows to pass a string instead of an array of string in the serialization context when only one group if used.
Before:
After: