Skip to content

Revert "bug #26138 [HttpKernel] Catch HttpExceptions when templating is not installed (cilefen)" #27516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27212
License MIT
Doc PR -

This reverts commit b213c5a, reversing
changes made to 61af0e3.

This breaks BC and is more like a new feature, let's move this on master.

…lating is not installed (cilefen)"

This reverts commit b213c5a, reversing
changes made to 61af0e3.
@chalasr
Copy link
Member

chalasr commented Jun 6, 2018

c93c9a5 will need to be reverted when merging this into 4.1.

@nicolas-grekas nicolas-grekas merged commit c6acad7 into symfony:3.4 Jun 6, 2018
nicolas-grekas added a commit that referenced this pull request Jun 6, 2018
…templating is not installed (cilefen)" (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

Revert "bug #26138 [HttpKernel] Catch HttpExceptions when templating is not installed (cilefen)"

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27212
| License       | MIT
| Doc PR        | -

This reverts commit b213c5a, reversing
changes made to 61af0e3.

This breaks BC and is more like a new feature, let's move this on master.

Commits
-------

c6acad7 Revert "bug #26138 [HttpKernel] Catch HttpExceptions when templating is not installed (cilefen)"
@nicolas-grekas nicolas-grekas deleted the http-x-revert branch June 6, 2018 11:01
takeit added a commit to takeit/web-publisher that referenced this pull request Jun 12, 2018
takeit added a commit to SuperdeskWebPublisher/SWPBridgeBundle that referenced this pull request Jun 12, 2018
This was referenced Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants