[FrameworkBundle] give access to non-shared services when using test.service_container #27528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jun 6, 2018
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #27488 |
| License | MIT |
| Doc PR | - |
stof
reviewed
Jun 6, 2018
| @@ -32,6 +32,10 @@ public function process(ContainerBuilder $container) | |||
|
|
|||
| foreach ($definitions as $id => $definition) { | |||
| if ($id && '.' !== $id[0] && (!$definition->isPublic() || $definition->isPrivate()) && !$definition->getErrors() && !$definition->isAbstract()) { | |||
| if (!$definition->isShared()) { | |||
| $definition->setShared(true); | |||
There was a problem hiding this comment.
wouldn't this cause issues regarding inlining ? Rules are not the same for shared and not shared services.
There was a problem hiding this comment.
It will change the resulting inlining yes that's the goal, but inlining is only an optimization: it has no external side effect, so this is neutral, behavior wise.
…service_container
a4dc1ee to
516ff5a
Compare
|
Implementation updated, with logic added to the inlining pass: when a non-shared service is weak-referenced, it cannot be inlined. |
|
(deps=high failure will be fixed when this is merged up to master.) |
stof
approved these changes
Jun 14, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Jun 15, 2018
…using test.service_container (nicolas-grekas) This PR was merged into the 4.1 branch. Discussion ---------- [FrameworkBundle] give access to non-shared services when using test.service_container | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27488 | License | MIT | Doc PR | - Commits ------- 516ff5a [FrameworkBundle] give access to non-shared services when using test.service_container
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Nov 12, 2021
…s are involved (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] fix inlining when non-shared services are involved | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #43980 | License | MIT | Doc PR | - I'm unable to write a service graph that hits the bug, but this is still fixing the referenced issue appropriately. As a reminder, since #27528, we don't inline non-shared service as soon as they're referenced by a service locator. But when doing so, we need to ensure that the shared services referenced by such non-inlined-non-shared services are not themselves inlined, since that'd break the non-inlined-non-shared services. This patch does it :) Commits ------- 3ff048b [DependencyInjection] fix inlining when non-shared services are involved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.