[Cache] Improve perf of array-based pools #27563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
05b84b1 to
995cc8d
Compare
|
(failure is a false-positive.) |
stof
reviewed
Jun 12, 2018
| $value = serialize($value); | ||
| } | ||
| } elseif (null !== $value && !\is_scalar($value)) { |
There was a problem hiding this comment.
shouldn't null be serialized too ?
995cc8d to
657d8c7
Compare
|
@nicolas-grekas it seems to duplicate the same logic in ArrayAdapter and ArrayCache. Should part of it be moved to the ArrayTrait to be shared ? |
7ce8c1d to
8bb8e83
Compare
|
@stof done |
8bb8e83 to
28981c4
Compare
28981c4 to
92a2d47
Compare
|
PR ready |
fabpot
approved these changes
Jun 18, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 18, 2018
…kas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Cache] Improve perf of array-based pools | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - - skip key validation when key is already known - remove overhead in `ArrayCache::get()` via inlining - don't store simple values in serialized format when not needed, preserving COW ~~Needs #27565 to be green.~~ Commits ------- 92a2d47 [Cache] Improve perf of array-based pools
This was referenced Nov 3, 2018
Closed
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2018
This PR was merged into the 4.2 branch. Discussion ---------- [Cache] Fix undefined variable in ArrayTrait | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | After upgrading my project to 4.2 my tests failed with a message that `$key` variable is missing here: https://github.com/symfony/symfony/blob/e81285249b780a11ed209a79fa77c1f6ea6da67b/src/Symfony/Component/Cache/Traits/ArrayTrait.php#L131 which seems to be introduced with PR #27563. So I added that variable to the trait and method calls (are there any other?). This is internal class so I guess noone is using it anywhere. Anyway, my tests pass with this fix. Commits ------- b0b5937 Fix undefined variable in cache ArrayTrait
symfony-splitter
pushed a commit
to symfony/cache
that referenced
this pull request
Dec 13, 2018
This PR was merged into the 4.2 branch. Discussion ---------- [Cache] Fix undefined variable in ArrayTrait | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | After upgrading my project to 4.2 my tests failed with a message that `$key` variable is missing here: https://github.com/symfony/symfony/blob/e81285249b780a11ed209a79fa77c1f6ea6da67b/src/Symfony/Component/Cache/Traits/ArrayTrait.php#L131 which seems to be introduced with PR symfony/symfony#27563. So I added that variable to the trait and method calls (are there any other?). This is internal class so I guess noone is using it anywhere. Anyway, my tests pass with this fix. Commits ------- b0b5937d1d Fix undefined variable in cache ArrayTrait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayCache::get()via inliningNeeds #27565 to be green.