[FrameworkBundle][SecurityBundle] Moved security expression providers pass logic to SecurityBundle #27611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Jun 15, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | ~ |
| License | MIT |
| Doc PR | ~ |
|
We probably need to make SecurityBundle conflict with older versions of FrameworkBundle to ensure we don't end up with double registration |
linaori
suggested changes
Jun 15, 2018
| */ | ||
| public function process(ContainerBuilder $container) | ||
| { | ||
| if ($container->has('security.expression_language')) { |
There was a problem hiding this comment.
This can be a guard clause now
There was a problem hiding this comment.
If the code remains cleans and small with one indent, I would keep a readable true condition here. I'll wait for other opinions before changing the style.
50a09da to
0869588
Compare
00631cf to
70f6708
Compare
|
Failures unrelated. Status: needs review |
nicolas-grekas
approved these changes
Jun 17, 2018
| @@ -46,7 +46,7 @@ | |||
| "conflict": { | |||
| "symfony/var-dumper": "<3.4", | |||
| "symfony/event-dispatcher": "<3.4", | |||
| "symfony/framework-bundle": "<4.1.1", | |||
| "symfony/framework-bundle": "<4.2", | |||
There was a problem hiding this comment.
L33 should bump to 4.2 also
| public function __construct(bool $handleSecurityLanguageProviders = true) | ||
| { | ||
| if ($handleSecurityLanguageProviders) { | ||
| @trigger_error(sprintf('Registering services tagged with "security.expression_language_provider" with "%s" is deprecated since Symfony 4.2, use the "%s" instead.', __CLASS__, SecurityExpressionLanguageProvidersPass::class), E_USER_DEPRECATED); |
There was a problem hiding this comment.
I'd suggest removing the first "with".
| @@ -6,6 +6,7 @@ CHANGELOG | |||
|
|
|||
| * Allowed configuring taggable cache pools via a new `framework.cache.pools.tags` option (bool|service-id) | |||
| * Deprecated auto-injection of the container in AbstractController instances, register them as service subscribers instead | |||
| * Deprecated the processing of services tagged `security.expression_language_provider` in favor of the new SecurityBundle pass | |||
There was a problem hiding this comment.
Deprecated processing of services tagged security.expression_language_provider in favor of a new AddExpressionLanguageProvidersPass in SecurityBundle.
… pass logic to SecurityBundle
70f6708 to
a8017be
Compare
|
Thank you @HeahDude. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 19, 2018
…ssion providers pass logic to SecurityBundle (HeahDude) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle][SecurityBundle] Moved security expression providers pass logic to SecurityBundle | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- a8017be [FrameworkBundle][SecurityBundle] Moved security expression providers pass logic to SecurityBundle
nicolas-grekas
pushed a commit
that referenced
this pull request
Jun 19, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Jun 19, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] Fixed tests added in #27611 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | ~ | License | MIT | Doc PR | ~ <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- be97006 [FrameworkBundle] Fixed tests added in #27611
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.