[HttpFoundation] missing namespace for RedisProxy #27754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coincidentally I spotted this also yesterday :) |
|
Another option is to just remove the check for it. Wouldn't break anything since it never worked. Note that RedisProxy exists because the Redis class used to be incompatible with autogenerated lazy proxies. That's not the case anymore since phpredis 4. |
|
@nicolas-grekas the |
nicolas-grekas
approved these changes
Jun 28, 2018
|
Thank you @bonfante. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2018
This PR was submitted for the master branch but it was squashed and merged into the 4.1 branch instead (closes #27754). Discussion ---------- [HttpFoundation] missing namespace for RedisProxy I think the intention was to check if is instance of \Symfony\Component\Cache\Traits\RedisProxy | Q | A | ------------- | --- | Branch? | 4.1 (becareful when merging) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- 8e0acfc [HttpFoundation] missing namespace for RedisProxy
|
Nice, my first commit on symfony 😄 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the intention was to check if is instance of \Symfony\Component\Cache\Traits\RedisProxy